Bug 15231 - add 256x256 size to hicolor.
Summary: add 256x256 size to hicolor.
Status: RESOLVED FIXED
Alias: None
Product: Specifications
Classification: Unclassified
Component: desktop-entry (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Alexander Larsson
QA Contact:
URL:
Whiteboard:
Keywords:
: 21961 25627 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-27 14:09 UTC by Jakub Steiner
Modified: 2015-05-20 09:22 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
adds 256x256 size to the hicolor skeleton theme. (13.43 KB, patch)
2008-03-27 14:09 UTC, Jakub Steiner
Details | Splinter Review
Those should actually be of type Scalable (13.40 KB, patch)
2008-03-27 14:13 UTC, Jakub Steiner
Details | Splinter Review
Final touch for better 256x256 support (13.48 KB, patch)
2009-12-04 08:03 UTC, Vincent Untz
Details | Splinter Review

Description Jakub Steiner 2008-03-27 14:09:25 UTC
Created attachment 15517 [details] [review]
adds 256x256 size to the hicolor skeleton theme.

The attached patch adds the 256x256px size to the hicolor skeleton theme to allow existence of high resolution icon themes.
Comment 1 Jakub Steiner 2008-03-27 14:13:55 UTC
Created attachment 15518 [details] [review]
Those should actually be of type Scalable
Comment 2 Alexander Larsson 2008-03-28 01:39:25 UTC
This didn't apply to cvs as it had some extra stock/emoticon that was not there. It also duplicated the 256x256 dirs in the Directories key.
I fixed that and commited.
Comment 3 Alexander Larsson 2009-09-25 06:02:32 UTC
*** Bug 21961 has been marked as a duplicate of this bug. ***
Comment 4 Jakub Steiner 2009-10-09 13:55:08 UTC
There's one more thing that doesn't make this quite work -- You've changed the Type form Scalable to Threshold (and the threshold is the default of 2). This way the 256x256 icon is used only for target canvas 254px-258px if I'm not mistaken. 

My intention was that if the high-res icon exists, it should be used from 64px to 256px and be of Type=Scalable. And yea if it exists it takes precedence over scalable which never gets used. So I guess those 256x256 should be:

Type=Scalable
MinSize=64
MaxSize=256
Size=256
Comment 5 Vincent Untz 2009-12-03 19:45:59 UTC
Hrm, also, I'd guess Makefile.in should create the directories.
Comment 6 Vincent Untz 2009-12-03 19:54:25 UTC
Oh, and, hrm, the patch added document and generic contexts for 256x256, but those contexts don't exist elsewhere.
Comment 7 Vincent Untz 2009-12-04 08:03:43 UTC
Created attachment 31745 [details] [review]
Final touch for better 256x256 support

This should fix everything mentioned in the bug -- creating the directories, removing the contexts that shouldn't be there and correct minsize/maxsize.
Comment 8 walch.martin 2009-12-13 19:34:33 UTC
*** Bug 25627 has been marked as a duplicate of this bug. ***
Comment 9 Alexander Larsson 2010-01-13 02:16:04 UTC
pushed to master
Comment 10 Alexander Larsson 2010-01-13 02:30:19 UTC
Also, i released 0.12 with this at:
http://icon-theme.freedesktop.org/wiki/HicolorTheme


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.