| Summary: | Mips build fix | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Stefan Dirsch <sndirsch> | ||||||
| Component: | Server/General | Assignee: | Egbert Eich <eich> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | high | CC: | eich, mat, matthieu.herrb, roland.mainz | ||||||
| Version: | git | ||||||||
| Hardware: | Other | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Stefan Dirsch
2004-10-09 11:08:14 UTC
Created attachment 1054 [details] [review] p_mips-fixes.diff How come you patch xfree86.cf ? It's been replaced with xorg.cf afaict. You're right. This hunk should be moved to xorg.conf. I didn't notice that, because I set DefaultGcc2MipsOpt in host.def. I'll attach a new patch. Created attachment 1056 [details] [review] p_mips-fixes.diff.new Needs to be discussed outside of Bugzilla first. I claim that this patch is slightly wrong. What if HasGcc2 isn't defined? Either it is always true then we don't need to check this or it is not then we need to be prepared to have another define for DefaultGcc2MipsOpt. Who is the original author of this? Hmm ... but then DefaultGcc2PpcOpt is broken as well. I assume that it simply should be empty, when no gcc2 is used and isn't defined otherwise (e.g. host.def). BTW, this was the main reason for introducing this, so I can set this in our host.def to $RPM_OPT_FLAGS, our default gcc defines for building packages. The original author of this patch is Adrian Schröter (SuSE). Reopen for discussion. This still needs to be investigated and tested by Egbert. Please don't commit any attached patches yet. The hunks for setting OptimizedCDebugFlags and DefaultGcc2MipsOpt are meanwhile in CVS head. The DoLoadableServer setting (to "YES") needs to be done in host.def - if wanted. Closing as FIXED. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.