Bug 1574 - Mips build fix
Summary: Mips build fix
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other Linux (All)
: high normal
Assignee: Egbert Eich
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-09 11:08 UTC by Stefan Dirsch
Modified: 2005-04-15 17:43 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:

Attachments
p_mips-fixes.diff (1.09 KB, patch)
2004-10-09 11:08 UTC, Stefan Dirsch 		no flags Details | Splinter Review
p_mips-fixes.diff.new (1.24 KB, patch)
2004-10-09 14:58 UTC, Stefan Dirsch 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Stefan Dirsch 2004-10-09 11:08:14 UTC 
I'll attach a patch, which fixes build on Mips.
Comment 1 Stefan Dirsch 2004-10-09 11:08:37 UTC 
Created attachment 1054 [details] [review]
p_mips-fixes.diff
Comment 2 Matthieu Herrb 2004-10-09 12:45:17 UTC 
How come you patch xfree86.cf ? It's been replaced with xorg.cf afaict.
Comment 3 Stefan Dirsch 2004-10-09 14:53:28 UTC 
You're right. This hunk should be moved to xorg.conf. I didn't notice that, 
because I set DefaultGcc2MipsOpt in host.def. I'll attach a new patch.
Comment 4 Stefan Dirsch 2004-10-09 14:58:59 UTC 
Created attachment 1056 [details] [review]
p_mips-fixes.diff.new
Comment 5 Stefan Dirsch 2004-10-11 02:32:51 UTC 
Needs to be discussed outside of Bugzilla first.
Comment 6 Egbert Eich 2004-10-17 01:32:43 UTC 
I claim that this patch is slightly wrong.
What if HasGcc2 isn't defined? Either it is always true then we don't need to
check this or it is not then we need to be prepared to have another define for 
DefaultGcc2MipsOpt.
Who is the original author of this?
Comment 7 Stefan Dirsch 2004-10-17 03:34:49 UTC 
Hmm ... but then DefaultGcc2PpcOpt is broken as well. I assume that it simply 
should be empty, when no gcc2 is used and isn't defined otherwise (e.g. 
host.def). BTW, this was the main reason for introducing this, so I can set 
this in our host.def to $RPM_OPT_FLAGS, our default gcc defines for building 
packages. The original author of this patch is Adrian Schröter (SuSE).
Comment 8 Stefan Dirsch 2004-10-26 22:08:53 UTC 
Reopen for discussion.
Comment 9 Stefan Dirsch 2004-10-26 22:11:19 UTC 
This still needs to be investigated and tested by Egbert. Please don't commit 
any attached patches yet.
Comment 10 Stefan Dirsch 2005-04-16 10:43:03 UTC 
The hunks for setting OptimizedCDebugFlags and DefaultGcc2MipsOpt are 
meanwhile in CVS head. The DoLoadableServer setting (to "YES") needs to be 
done in host.def - if wanted. Closing as FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.