| Summary: | xterm should use the new IUTF8 flag | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Stefan Dirsch <sndirsch> | ||||
| Component: | App/xterm | Assignee: | Stefan Dirsch <sndirsch> | ||||
| Status: | RESOLVED DUPLICATE | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | high | CC: | alan.coopersmith, egmont, eich, ienup.sung, mat, mfabian, roland.mainz, Steve.Swales | ||||
| Version: | git | ||||||
| Hardware: | All | ||||||
| OS: | Linux (All) | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Stefan Dirsch
2004-10-10 08:11:59 UTC
Created attachment 1061 [details] [review] p_xterm_iutf8.diff Needs to be discussed outside of Bugzilla first. . I'll send this patch to T. Dickey. I've sent this patch now to Thomas E. Dickey for inclusion for a future release. No reply yet. Date: Thu, 14 Oct 2004 07:24:44 -0400 (EDT) On Thu, 14 Oct 2004, Stefan Dirsch wrote: > Hi Thomas > > I'll attach another patch, which makes use of the new IUTF8 Linux > kernel flag. Maybe you consider to include this patch to a future > xterm release. I saw it, noticed that it needs some more work (it's on my to-do list). -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net One troubling aspect of this is that it will tend to decrease portability of applications, is unrelated to any standard. Bug #1841 cites an example of this. *** Bug 1841 has been marked as a duplicate of this bug. *** I tried Stefan's patch. It's okay for me if I have "*locale: false". However if I have "*locale: true" and hence use luit to convert to latinX then the IUTF8 flag of the terminal is always set, even if I use Latin2 (LANG=hu_HU) mode where it shouldn't be set. So at least luit has to be patched also... CC:'ing i18n/X11 folks from Sun to take a look at the patch, too... well, then I have this chunk now
(am trying to tie off loose ends to close out patch #197):
#if OPT_WIDE_CHARS && defined(linux) && defined(IUTF8)
#if OPT_LUIT_PROG
if (command_to_exec_with_luit == 0)
#endif
if (screen->utf8_mode)
tio.c_iflag |= IUTF8;
#endif
I committed the change noted in xterm patch #197. Thanks! *** This bug has been marked as a duplicate of 1979 *** Oh, wait please! Please make sure that not only xterm is correct on its own, but even standalone luit properly sets or clears this flag depending on whether it is run with an utf8 locale or not. This is because luit is not only used by xterm, it's really usable on its own. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.