Bug 1578 - xterm should use the new IUTF8 flag
Summary: xterm should use the new IUTF8 flag
Status: RESOLVED DUPLICATE of bug 1979
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xterm (show other bugs)
Version: git
Hardware: All Linux (All)
: high enhancement
Assignee: Stefan Dirsch
QA Contact:
URL:
Whiteboard:
Keywords:
: 1841 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-10 08:11 UTC by Stefan Dirsch
Modified: 2004-11-30 07:01 UTC (History)
8 users (show)

See Also:
i915 platform:
i915 features:


Attachments
p_xterm_iutf8.diff (522 bytes, patch)
2004-10-10 08:12 UTC, Stefan Dirsch
no flags Details | Splinter Review

Description Stefan Dirsch 2004-10-10 08:11:59 UTC
I'll attach a patch, which uses the new Kernel IUTF8 flag.
Comment 1 Stefan Dirsch 2004-10-10 08:12:37 UTC
Created attachment 1061 [details] [review]
p_xterm_iutf8.diff
Comment 2 Stefan Dirsch 2004-10-11 02:35:22 UTC
Needs to be discussed outside of Bugzilla first.  
 
Comment 3 Stefan Dirsch 2004-10-12 15:09:50 UTC
. 
Comment 4 Stefan Dirsch 2004-10-12 15:10:50 UTC
I'll send this patch to T. Dickey. 
Comment 5 Stefan Dirsch 2004-10-14 04:11:41 UTC
I've sent this patch now to Thomas E. Dickey for inclusion for a future 
release. No reply yet. 
Comment 6 Stefan Dirsch 2004-10-14 05:24:32 UTC
Date: Thu, 14 Oct 2004 07:24:44 -0400 (EDT) 
 
On Thu, 14 Oct 2004, Stefan Dirsch wrote: 
 
> Hi Thomas 
> 
> I'll attach another patch, which makes use of the new IUTF8 Linux 
> kernel flag. Maybe you consider to include this patch to a future 
> xterm release. 
 
I saw it, noticed that it needs some more work (it's on my to-do list). 
 
-- 
Thomas E. Dickey 
http://invisible-island.net 
ftp://invisible-island.net 
 
Comment 7 Thomas Dickey 2004-11-22 17:05:42 UTC
One troubling aspect of this is that it will tend to decrease
portability of applications, is unrelated to any standard.
Bug #1841 cites an example of this.
Comment 8 Egmont Koblinger 2004-11-23 05:37:57 UTC
*** Bug 1841 has been marked as a duplicate of this bug. ***
Comment 9 Egmont Koblinger 2004-11-23 06:33:07 UTC
I tried Stefan's patch. It's okay for me if I have "*locale: false".
However if I have "*locale: true" and hence use luit to convert to latinX then
the IUTF8 flag of the terminal is always set, even if I use Latin2 (LANG=hu_HU)
mode where it shouldn't be set.

So at least luit has to be patched also...
Comment 10 Roland Mainz 2004-11-23 07:16:31 UTC
CC:'ing i18n/X11 folks from Sun to take a look at the patch, too...
Comment 11 Thomas Dickey 2004-11-29 18:15:42 UTC
well, then I have this chunk now
(am trying to tie off loose ends to close out patch #197):

#if OPT_WIDE_CHARS && defined(linux) && defined(IUTF8)
#if OPT_LUIT_PROG
                if (command_to_exec_with_luit == 0)
#endif
                if (screen->utf8_mode)
                    tio.c_iflag |= IUTF8;
#endif
Comment 12 Thomas Dickey 2004-11-30 18:02:41 UTC
I committed the change noted in xterm patch #197.
Comment 13 Stefan Dirsch 2004-11-30 20:32:36 UTC
Thanks! 

*** This bug has been marked as a duplicate of 1979 ***
Comment 14 Egmont Koblinger 2004-12-01 02:01:42 UTC
Oh, wait please!
Please make sure that not only xterm is correct on its own, but even
standalone luit properly sets or clears this flag depending on whether
it is run with an utf8 locale or not.
This is because luit is not only used by xterm, it's really usable on its own.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.