Bug 15960

Summary:	"Done" and "Error" columns are redundant with each other
Product:	swfdec	Reporter:	Matthew Paul Thomas <mpt>
Component:	plugin	Assignee:	swfdec ml <swfdec>
Status:	RESOLVED FIXED	QA Contact:	swfdec ml <swfdec>
Severity:	minor
Priority:	medium
Version:	0.6.0
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	marge done and error column merge done and error column - try 2 merge done and error column - try 3 distinguish file with unknown size

Description Matthew Paul Thomas 2008-05-16 03:57:02 UTC

swfdec-mozilla 0.6.0-2ubuntu1, Ubuntu 8.04

In the "Properties" window for a Flash object, there is a "Done" column showing download progress for each item, and an "Error" column showing whether the item had an error.

Issues with these columns:

* When an item is completely downloaded, the progress bar is still present. Progress bars should disappear within a couple of seconds of reaching 100%.

* The error cell looks like a checkable checkbox, but isn't.

* If an item is successfully downloaded, it didn't have an error; and if it had an error, it wasn't successfully downloaded. So the columns can be merged.

Safari's Activity window shows how to present progress, size (instead of percentage progress), and errors in a single column.
<http://www.myokyawhtun.com/wp-content/uploads/2008/03/safari-activity.jpg>

Comment 1 Riccardo Magliocchetti 2008-05-22 13:26:26 UTC

Created attachment 16697 [details] [review]
marge done and error column

Attached a patch that implement the suggestion. Should add i'm not able to find a flash file that give an error so never excercised that path. The patch should be applied on top of the other one i posted for 15958 and 15959 to avoid merge issues.

Comment 2 Benjamin Otte 2008-05-24 03:12:10 UTC

You seem to be used to languages that do automatic memory management. ;)
The return value of g_format_size_for_display() must be freed.
Also, I'm not sure if using red on errors is a good idea as it might look odd on some themes. So we'd better use something theme-agnostic, like bold, if we use a special marker at all.

Comment 3 Riccardo Magliocchetti 2008-05-24 04:50:23 UTC

Created attachment 16712 [details] [review]
 merge done and error column - try 2

(In reply to comment #2)
> You seem to be used to languages that do automatic memory management. ;)
> The return value of g_format_size_for_display() must be freed.

You are right, fixed.

> Also, I'm not sure if using red on errors is a good idea as it might look odd
> on some themes. So we'd better use something theme-agnostic, like bold, if we
> use a special marker at all.

Ok, in case of error i've removed the red color for text.

Comment 4 Riccardo Magliocchetti 2008-05-24 05:17:59 UTC

Created attachment 16713 [details] [review]
merge done and error column - try 3  

Removed a hunk of a previous patch.

Comment 5 Riccardo Magliocchetti 2008-05-24 05:36:37 UTC

Created attachment 16714 [details] [review]
distinguish file with unknown size

Use a different string format for files with size unknown as discuessed on irc.

Comment 6 Riccardo Magliocchetti 2008-06-17 04:39:59 UTC

This is in git now.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.