Bug 16047

Summary:	No avatar for muc contacts
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED WORKSFORME	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Xavier Claessens 2008-05-21 04:40:09 UTC

When I join a Jabber muc using Empathy I see only my self own avatar. Looking at Empathy debug messages here is what happens:
 - Empathy calls GetKnownAvatarTokens([all members of the muc])
 - Empathy gets in the reply all tokens. The self avatar token is found in cache so empathy call RequestAvatars([All members but without self handle])
 - Gabble never emit AvatarRetrieved...

Comment 1 Will Thompson 2011-05-30 11:07:05 UTC

Heh, interestingly I currently see pretty much exactly the opposite: avatars for most other contacts in a room show up, but not my own.

In my quick testing, I found that Pidgin does not include an avatar hash in the <presence/> it sends to MUCs, so there's no way we're gonna get their avatars. Gabble could conceivably be sneaky and, if a MUC contact has no avatar token but we know their real JID and we do have a token for that JID, copy that token over to the MUC contact.

I got avatars for all the other contacts in rooms that I tested—though I think they were mostly cached, so more testing is necessary with an empty avatar cache and freshly-started Empathy. I'm prepared to believe that Gabble mishandles the replies to vCard queries for contacts in MUCs. That said: ContactInfo works fine in MUCs, so who knows! It's been exactly three years since this bug was filed, soooo … a few things have changed.

Comment 2 Will Thompson 2011-05-31 04:15:58 UTC

Okay, the self-handle thing is bug 32017.

I tried this again with a clean cache in a MUC where I don't have all the participants on my roster (so Empathy wouldn't have fetched the data for their hash from their non-MUC-specific handle), and got avatars for most of the contacts. I didn't exhaustively check all the avatar-less contacts but the people I recognised were likely to be using Pidgin: so no avatars are expected.

So I'm gonna mark this WFM and go fix bug 32017.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.