Original bug report: https://bugzilla.gnome.org/show_bug.cgi?id=636207 Gabble doesn't return any avatar token on our self channel specific handle in mucs, so Empathy can't display it.
Yo, I'm working on this! It's a regression from the WockyMuc rewrite, causing presence stanzas never to reach the handler in Gabble which scrapes the vcard-temp:x:update element out of them. I accidentally got sucked into cleaning up other bits of the MUC while I was there … I'll push a pair of branches tomorrow.
http://cgit.collabora.com/git/user/wjt/wocky.git/log/?h=fd.o-32017-muc-self-avatar http://cgit.collabora.com/git/user/wjt/telepathy-gabble-wjt.git/log/?h=fd.o-32017-muc-self-avatar I wrote a long message about how I'm not very happy with the fix, and then a combination of Chrome, Bugzilla and Termite Misdirection ate it. I don't really understand why avatars for other MUC contacts work even when the WockyMuc object swallows the <presence/> stanza, but for the self handle we have to let further handlers run. But life is too short, I've already spent way too long on this.
Looks good to me.
Thanks, merged to master. I'll release 0.13.0 tomorrow or something with this and other things. I'm not sure if it's worth the hassle of branching Wocky to backport the fix for just this bug to 0.12. I'll leave the bug open while thinking about it.
Well, here's an equivalent fix without all the other refactoring for Gabble 0.12: http://cgit.collabora.com/git/user/wjt/wocky.git/commit/?h=gabble-0.12&id=955e09193a3935ea496545b507a9ce667b2693fe If no-one objects I'll push the gabble-0.12 branch to Wocky upstream, shove it into Gabble and release 0.12.1 with it (as well as other accumulated fixxes).
Seems fine to me.
Cool. So, fixed in 0.12.1 (for which I've pushed the tags but not the tarball due to Annarchy being broken) and master.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.