Bug 1628

Summary:

eliminate text relocation in BUSmemcpy.S

Product:

xorg

Reporter:

Adam Jackson <ajax>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

high

Version:

git

Hardware:

x86 (IA32)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
picify-busmemcpy.patch	none

Description Adam Jackson 2004-10-13 14:51:40 UTC

hw/xfree86/os-support/misc/BUSmemcpy.S is not PIC code.  this forces the server
binary to have a text relocation, which hurts performance (marginally) and
prevents the executable from being being built -fPIE (enables runtime address
space randomization security feature in PaX).

credit to the PaX Team.

nothing in-tree ever calls xf86BusToMem or xf86MemToBus, so we could just delete
this code...

Comment 1 Adam Jackson 2004-10-13 14:52:19 UTC

Created attachment 1104 [details] [review]
picify-busmemcpy.patch

Comment 2 Adam Jackson 2004-10-14 16:10:57 UTC

fixed in HEAD, closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.