Bug 1628 - eliminate text relocation in BUSmemcpy.S
Summary: eliminate text relocation in BUSmemcpy.S
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high trivial
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-13 14:51 UTC by Adam Jackson
Modified: 2004-10-13 23:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
picify-busmemcpy.patch (1.05 KB, patch)
2004-10-13 14:52 UTC, Adam Jackson 		no flags Details | Splinter Review
View All

Description Adam Jackson 2004-10-13 14:51:40 UTC 
hw/xfree86/os-support/misc/BUSmemcpy.S is not PIC code.  this forces the server
binary to have a text relocation, which hurts performance (marginally) and
prevents the executable from being being built -fPIE (enables runtime address
space randomization security feature in PaX).

credit to the PaX Team.

nothing in-tree ever calls xf86BusToMem or xf86MemToBus, so we could just delete
this code...
Comment 1 Adam Jackson 2004-10-13 14:52:19 UTC 
Created attachment 1104 [details] [review]
picify-busmemcpy.patch
Comment 2 Adam Jackson 2004-10-14 16:10:57 UTC 
fixed in HEAD, closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.