Bug 16619

Created attachment 92928 [details] [review]
Respect orientation when selecting words

Attached is a patch which improves selection of words when PDF is rotated by multiples of 90°. It sets correct bounds on various visit*() functions.

The patch doesn't solve all problems related to this. There are still problems with order of selected lines and blocks when multiple blocks are selected.

The problem with correct order of lines is easier to fix but I have not a patch ready yet. The problem with correct order of blocks is a little bit harder since it needs to correct flows.


The main problem why I started to look into this was that poppler shows this warning on some PDFs (see next attachment):

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug


Btw, the patch doesn't fix the problem shown on the Pedro's screenshot but it is related to the name of this bug.

Created attachment 92929 [details]
reproducer showing "Invalid rectangle" error when selecting text

Problem confirmed:

1) lsb_release -rd
Description:	Ubuntu Vivid Vervet (development branch)
Release:	15.04

2) libpoppler 0.28.1-1ubuntu1 

apt-cache policy evince
evince:
  Installed: 3.14.1-0ubuntu1
  Candidate: 3.14.1-0ubuntu1
  Version table:
 *** 3.14.1-0ubuntu1 0
        500 http://us.archive.ubuntu.com/ubuntu/ vivid/main amd64 Packages
        100 /var/lib/dpkg/status

3) What is expected to happen via the attached document is that one may highlight the text that has been rotated at a 45 degree angle, one row at a time, just like Adobe Reader 10.x:
https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/245620/+attachment/314937/+files/m1.pdf

4) What happens instead is it highlights parts of the line, along with others, as per the attached screenshot:
https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/245620/+attachment/314936/+files/Capture-1.png

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/499.