Bug 17595

Summary: linux-core/drm_compat.c:220 too few arguments for drm_bo_wait()
Product: DRI Reporter: Bryan Stine <battousai>
Component: DRM/otherAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Correct number of args to drm_bo_wait() call none

Description Bryan Stine 2008-09-15 13:07:55 UTC 
Created attachment 18888 [details] [review]
Correct number of args to drm_bo_wait() call

A Gentoo user reported a build error with a drm git snapshot from July, against a 2.6.20 kernel.

Line 220 in linux-core/drm_compat.c is as follows (inside the function drm_bo_vm_fault() ):
err = drm_bo_wait(bo, 0, 1, 0);

drm_bo_wait() actually accepts five arguments, with the fifth being (int)check_unfenced.

There's actually an identical call in drm_bo_vm_nopfn() with the correct number of args and check_unfenced=1, so maybe this is the result of a change that got missed in that particular spot.

Anyway, assuming that fifth arg should be 1 like in the call in drm_bo_vm_nopfn(), I've provided a one-liner patch to that effect. It looks like this can still be applied to current git.

Thanks.
Comment 1 Matt Turner 2010-12-02 20:06:21 UTC 
Closing, must be fixed by now.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.