Bug 17595 - linux-core/drm_compat.c:220 too few arguments for drm_bo_wait()
Summary: linux-core/drm_compat.c:220 too few arguments for drm_bo_wait()
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/other (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-15 13:07 UTC by Bryan Stine
Modified: 2010-12-02 20:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Correct number of args to drm_bo_wait() call (419 bytes, patch)
2008-09-15 13:07 UTC, Bryan Stine
no flags Details | Splinter Review

Description Bryan Stine 2008-09-15 13:07:55 UTC
Created attachment 18888 [details] [review]
Correct number of args to drm_bo_wait() call

A Gentoo user reported a build error with a drm git snapshot from July, against a 2.6.20 kernel.

Line 220 in linux-core/drm_compat.c is as follows (inside the function drm_bo_vm_fault() ):
err = drm_bo_wait(bo, 0, 1, 0);

drm_bo_wait() actually accepts five arguments, with the fifth being (int)check_unfenced.

There's actually an identical call in drm_bo_vm_nopfn() with the correct number of args and check_unfenced=1, so maybe this is the result of a change that got missed in that particular spot.

Anyway, assuming that fifth arg should be 1 like in the call in drm_bo_vm_nopfn(), I've provided a one-liner patch to that effect. It looks like this can still be applied to current git.

Thanks.
Comment 1 Matt Turner 2010-12-02 20:06:21 UTC
Closing, must be fixed by now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.