Bug 18133

Summary: Protocol visible side-effect on XCompositeRedirectWindow() and following XCompositeUnredirectWindow()
Product: xorg Reporter: Michael Vogt <mvo>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
URL: https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/278112
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Proposed fix none

Description Michael Vogt 2008-10-20 11:15:53 UTC 
Created attachment 19765 [details] [review]
Proposed fix

The attached patch prevents a protocol visible side-effect (XVisibilityEvent) on XCompositeRedirectWindow() followed by a XCompositeUnredirectWindow(). 

This problem shows up in gnome-screensaver with compiz and "unredirect fullscreen windows" enable (ubuntu bug #278112). A VisibilityNotify event is generated (first with obscured and than with unobscured) when the window swithces from redirected to unredirected. 

This is similar in spirit to http://cgit.freedesktop.org/xorg/xserver/commit/?id=a6a7fadbb03ee99312dfb15ac478ab3c414c1c0b that fixes a break of the keyboard lock.
Comment 1 Timo Aaltonen 2008-11-25 14:20:54 UTC 
fixed as commit c8472a74441838e16d0d3414db1fa7fe996868a9!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.