Bug 18133 - Protocol visible side-effect on XCompositeRedirectWindow() and following XCompositeUnredirectWindow()
Summary: Protocol visible side-effect on XCompositeRedirectWindow() and following XCom...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: https://bugs.launchpad.net/ubuntu/+so...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 11:15 UTC by Michael Vogt
Modified: 2008-11-25 14:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Proposed fix (351 bytes, patch)
2008-10-20 11:15 UTC, Michael Vogt 		no flags Details | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Vogt 2008-10-20 11:15:53 UTC 
Created attachment 19765 [details] [review]
Proposed fix

The attached patch prevents a protocol visible side-effect (XVisibilityEvent) on XCompositeRedirectWindow() followed by a XCompositeUnredirectWindow(). 

This problem shows up in gnome-screensaver with compiz and "unredirect fullscreen windows" enable (ubuntu bug #278112). A VisibilityNotify event is generated (first with obscured and than with unobscured) when the window swithces from redirected to unredirected. 

This is similar in spirit to http://cgit.freedesktop.org/xorg/xserver/commit/?id=a6a7fadbb03ee99312dfb15ac478ab3c414c1c0b that fixes a break of the keyboard lock.
Comment 1 Timo Aaltonen 2008-11-25 14:20:54 UTC 
fixed as commit c8472a74441838e16d0d3414db1fa7fe996868a9!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.