Bug 18513

Summary:	telepathy-haze from git errors on compile
Product:	Telepathy	Reporter:	Larry Reaves <larry>
Component:	haze	Assignee:	Will Thompson <will>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch via git diff src/connection-avatars.c

Description Larry Reaves 2008-11-12 21:06:17 UTC

Created attachment 20276 [details] [review]
patch via git diff src/connection-avatars.c

cc1: warnings being treated as errors
connection-avatars.c: In function ‘haze_connection_request_avatar’:
connection-avatars.c:271: error: format not a string literal and no format arguments
connection-avatars.c: In function ‘haze_connection_set_avatar’:
connection-avatars.c:345: error: format not a string literal and no format arguments
make[2]: *** [connection-avatars.o] Error 1


The attached patch fixes it for me.  Docs say for g_set_error we need a format string, and then arguments.  Someone is trying to pass in a string.  Removing the g_strdup_printf and moving the format string and arguments down fixes it.

Comment 1 Will Thompson 2008-11-13 02:35:55 UTC

Thanks! I slightly modified the patch (on my system, "%d" is not the format for a size_t; plus I converted tabs to spaces) and it's awaiting review in a branch containing another format string fix that was needed to compile without warnings on x86_64.

Comment 2 Will Thompson 2009-04-04 03:39:37 UTC

Fixed in 0.3.0. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.