Bug 18513 - telepathy-haze from git errors on compile
Summary: telepathy-haze from git errors on compile
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Will Thompson
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-12 21:06 UTC by Larry Reaves
Modified: 2009-04-04 03:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch via git diff src/connection-avatars.c (1.35 KB, patch)
2008-11-12 21:06 UTC, Larry Reaves
Details | Splinter Review

Description Larry Reaves 2008-11-12 21:06:17 UTC
Created attachment 20276 [details] [review]
patch via git diff src/connection-avatars.c

cc1: warnings being treated as errors
connection-avatars.c: In function ‘haze_connection_request_avatar’:
connection-avatars.c:271: error: format not a string literal and no format arguments
connection-avatars.c: In function ‘haze_connection_set_avatar’:
connection-avatars.c:345: error: format not a string literal and no format arguments
make[2]: *** [connection-avatars.o] Error 1


The attached patch fixes it for me.  Docs say for g_set_error we need a format string, and then arguments.  Someone is trying to pass in a string.  Removing the g_strdup_printf and moving the format string and arguments down fixes it.
Comment 1 Will Thompson 2008-11-13 02:35:55 UTC
Thanks! I slightly modified the patch (on my system, "%d" is not the format for a size_t; plus I converted tabs to spaces) and it's awaiting review in a branch containing another format string fix that was needed to compile without warnings on x86_64.
Comment 2 Will Thompson 2009-04-04 03:39:37 UTC
Fixed in 0.3.0. Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.