Bug 18634

Summary: [965gm] when DRI enabled, some programs using opengl CTD with `!brw->no_batch_wrap' Assertion
Product: Mesa Reporter: tom <thomas.meschede>
Component: Drivers/DRI/i965Assignee: Eric Anholt <eric>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: thomas.meschede
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: fix for assertion failure

Description tom 2008-11-20 05:55:11 UTC 
when running blender opening a certain file or when trying to run gridwars

the following error occurs (only when DRI Option is enabled):

In Blender:  (I added the file that is causing the crash as an attachment, you have to klikc on the layers to trigger the bug (layers are the small rectangles in the main window))

"blender: brw_vtbl.c:98: brw_new_batch: Assertion `!brw->no_batch_wrap' failed.
Aborted"


in gridwars (ubuntu package obtainable from here: http://www.getdeb.net/release/3393)

"gridwars: brw_vtbl.c:98: brw_new_batch: Assertion `!brw->no_batch_wrap' failed.
Aborted"

I think this is the "new" version of these bugs after the CTD was fixed...:

https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/120834
and
https://bugs.freedesktop.org/show_bug.cgi?id=9307

greetings, tom
Comment 1 tom 2008-11-20 06:01:59 UTC 
the blend file is apparently to big to upload it as an attacment to bugzille so here is a download link:

http://launchpadlibrarian.net/19807353/schoonerXI_damaged2.blend
Comment 2 Eric Anholt 2008-11-27 09:09:02 UTC 
Created attachment 20634 [details] [review]
fix for assertion failure

Here's a proposed fix for this that I came up with working on the same assertion failure in Eschalon Book 1.  Doing some of the same things that triggered it before is working now, but I'd like a bit more testing to be sure.
Comment 3 Eric Anholt 2008-11-28 17:35:56 UTC 
OK, being a blender novice, I think I tested it right -- blender schooner*blend, click on the boxes in the pair of 2x5 grids of them that are in the toolbar with the View, Select, and Object menus, then see things appear in the view (or not, most often).  It also definitely fixed the assertion error in the form I was tripping over it in Eschalon, so I think it's fixed.

commit 7855b2aef6bd9e9c2d73260b5cd166159b2525c6
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Nov 26 19:22:37 2008 -0800

    i965: Reduce fast-pathiness of brw_try_draw_prims, bringing in important checks.
    
    Later primitives, even if they caused a full state validate, wouldn't check
    that there was enough space in the batchbuffer, occasionally triggering the
    sanity check.  We also skipped the aperture space check, even if it would
    mean bringing in new programs and associated state.
Comment 4 tom 2008-11-29 02:08:50 UTC 
>OK, being a blender novice, I think I tested it right -- blender
>schooner*blend, click on the boxes in the pair of 2x5 grids of them that are in
>the toolbar with the View, Select, and Object menus, then see things appear in
>the view (or not, most often).  It also definitely fixed the assertion error in
>the form I was tripping over it in Eschalon, so I think it's fixed.

yepp... you did it right (with blender)... Thank you very much.

I myself beeing a Linux newby, when do you think can we expect this fix showing up in the main trunk? (I run Kubuntu 8.10 for example, will this bug automatically be fixed in one of the next updates? or shoudl i rather do it by myself?

greetings, tom
Comment 5 Adam Jackson 2009-08-24 12:31:07 UTC 
Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.