| Summary: | stretched panel size derivation incorrect? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Daniel Stone <daniel> | ||||
| Component: | Driver/Radeon | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | high | CC: | alexdeucher, roland.mainz, tjb | ||||
| Version: | git | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
Created attachment 1322 [details] [review] [FIXED_X11R68x] trivial patch yes, the patch looks good. I believe a similar patch was ok'ed on the xorg list a while back but never committed. I don't have the specs in front of me ATM, but as I recall this is correct. *** Bug 1109 has been marked as a duplicate of this bug. *** yeah, I was the one who proposed it Comment on attachment 1322 [details] [review] [FIXED_X11R68x] trivial patch make roland less angry Comment on attachment 1322 [details] [review] [FIXED_X11R68x] trivial patch committed to HEAD, please consider for 6.8.2 Comment on attachment 1322 [details] [review] [FIXED_X11R68x] trivial patch Approved in the 2004-12-06 release-wranglers conference call. Please do not commit it yourself, I'll do that later today... Comment on attachment 1322 [details] [review] [FIXED_X11R68x] trivial patch Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.98; previous revision: 1.365.2.97 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c,v <-- radeon_driver.c new revision: 1.19.2.5; previous revision: 1.19.2.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Patch checked-in into Xorg trunk and X11R6.8.x stable branch... ... marking bug as FIXED. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Looking at radeon_driver.c, the panel size derivation for stretched panels looks incorrect to me. It may be right; without specs, I don't know. CARD32 fp_vert_stretch = INREG(RADEON_FP_VERT_STRETCH); CARD32 fp_horz_stretch = INREG(RADEON_FP_HORZ_STRETCH); info->PanelPwrDly = 200; if (fp_vert_stretch & RADEON_VERT_STRETCH_ENABLE) { info->PanelYRes = (fp_vert_stretch>>12) + 1; [...] } if (fp_horz_stretch & RADEON_HORZ_STRETCH_ENABLE) { info->PanelXRes = ((fp_vert_stretch>>16) + 1) * 8; [...] } A simple but obvious patch to change the second usage of fp_vert_stretch to fp_horz_stretch is attached.