Bug 18925

Summary:	GNOME Goal: Clean up GLib and GTK+ includes
Product:	poppler	Reporter:	Luis Menina <liberforce>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://bugzilla.gnome.org/show_bug.cgi?id=563413
Whiteboard:
i915 platform:		i915 features:
Attachments:	simple patch

Description Luis Menina 2008-12-07 08:43:24 UTC

Correct applications or libraries that don't include
*only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful
to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

Comment 1 Luis Menina 2008-12-07 08:44:39 UTC

Created attachment 20870 [details] [review]
simple patch

Comment 2 Carlos Garcia Campos 2008-12-12 04:56:38 UTC

This was already reported and fixed. Thanks. 

*** This bug has been marked as a duplicate of bug 18240 ***

Comment 3 Luis Menina 2008-12-12 13:38:26 UTC

You're wrong, look at the patches. The patch in bug 18240 fixes compilation only for GDK_DISABLE_SINGLE_INCLUDES, while mine fixes  GDK_PIXBUF_DISABLE_SINGLE_INCLUDES *and* GTK_DISABLE_SINGLE_INCLUDES (and G_DISABLE_SINGLE_INCLUDES, but there are no deprecated GLib symbols used in poppler anyway).

Comment 4 Carlos Garcia Campos 2008-12-13 08:26:26 UTC

Yes, the attached patch didn't fix everything but I did so. See commits:

http://cgit.freedesktop.org/poppler/poppler/commit/?id=a84d272ffd2b593ac98148e71b83fba299c60fea
http://cgit.freedesktop.org/poppler/poppler/commit/?id=a5865dae5b414de5f6dbda2a512101050c374e06



*** This bug has been marked as a duplicate of bug 18240 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.