Bug 19684

Summary:	per_channel_manager_caps shouldn't be accessed directly
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	salut	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~jonny/telepathy-salut/log?h=contact-caps
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	30680, 31301
Bug Blocks:	24653

Description Guillaume Desmottes 2009-01-22 04:06:44 UTC

We have the same problem with SalutSelf->per_channel_manager_caps and SalutContact->per_channel_manager_caps in the requestotron-tubes-and-caps-with-complex-types-with-gibber-listener branch.

+++ This bug was initially created as a clone of Bug #19683 +++

Lot of components access, modify, create and destroy the GabblePresence->per_channel_manager_caps hash table which is not very OO friendly.

We should refactor code to add accessors and do that properly.

Comment 1 Simon McVittie 2010-10-07 08:05:01 UTC

I'd go further, and say "per_channel_manager_caps shouldn't exist". The referenced branch makes Salut behave more like Gabble, by importing large chunks of my capabilities refactoring from Gabble 0.9.

Comment 2 Jonny Lamb 2011-03-17 03:45:03 UTC

I've started looking at your branch.

Comment 3 Jonny Lamb 2011-03-17 05:52:02 UTC

Absolutely ridiculous. This is a great branch. I only had one little niggle which I've fixed in my branch on top of yours.

I'll get that reviewed and then we can GOGOGOGOGOGOGO!

Comment 4 Jonny Lamb 2011-03-17 06:01:20 UTC

Okay I merged this with master and fixed the conflicts and the new compiler warnings. I also fixed a leak. Go me.

Comment 5 Jonny Lamb 2011-03-17 07:57:18 UTC

Merged, woo! Thanks Simon!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.