Bug 20655

Summary:	do not hardcode make
Product:	shared-mime-info	Reporter:	Antoine Jacoutot <ajacoutot>
Component:	general	Assignee:	Jonathan Blandford <jrb>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	gilles.dartiguelongue
Version:	unspecified
Hardware:	Other
OS:	OpenBSD
Whiteboard:
i915 platform:		i915 features:
Attachments:	no hardcoding

Description Antoine Jacoutot 2009-03-14 01:22:19 UTC

shared-mime-info should not hardcode make but use $(MAKE) instead.
This is because `make' can behave differently amongst platforms. e.g. we set MAKE=gmake under OpenBSD because BSD make does not have the -C option.

Patch below fixed it.

Comment 1 Antoine Jacoutot 2009-03-14 01:22:58 UTC

Created attachment 23843 [details] [review]
no hardcoding

Comment 2 Pino Toscano 2009-03-14 02:46:22 UTC

*** Bug 20654 has been marked as a duplicate of this bug. ***

Comment 3 Bastien Nocera 2009-03-16 03:50:48 UTC

Patching Makefile.in is useless though...

* Makefile.am: Don't use "make" but "$(MAKE)" to call
our make, fixes build on *BSDs, spotted by Antoine Jacoutot
<ajacoutot@lphp.org> (Closes: #20655)

Comment 4 Bastien Nocera 2009-04-20 10:29:00 UTC

*** Bug 20522 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.