Bug 20655 - do not hardcode make
Summary: do not hardcode make
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other OpenBSD
: medium normal
Assignee: Jonathan Blandford
QA Contact:
: 20522 20654 (view as bug list)
Depends on:
Reported: 2009-03-14 01:22 UTC by Antoine Jacoutot
Modified: 2009-04-20 10:29 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

no hardcoding (313 bytes, patch)
2009-03-14 01:22 UTC, Antoine Jacoutot
Details | Splinter Review

Description Antoine Jacoutot 2009-03-14 01:22:19 UTC
shared-mime-info should not hardcode make but use $(MAKE) instead.
This is because `make' can behave differently amongst platforms. e.g. we set MAKE=gmake under OpenBSD because BSD make does not have the -C option.

Patch below fixed it.
Comment 1 Antoine Jacoutot 2009-03-14 01:22:58 UTC
Created attachment 23843 [details] [review]
no hardcoding
Comment 2 Pino Toscano 2009-03-14 02:46:22 UTC
*** Bug 20654 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2009-03-16 03:50:48 UTC
Patching Makefile.in is useless though...

* Makefile.am: Don't use "make" but "$(MAKE)" to call
our make, fixes build on *BSDs, spotted by Antoine Jacoutot
<ajacoutot@lphp.org> (Closes: #20655)
Comment 4 Bastien Nocera 2009-04-20 10:29:00 UTC
*** Bug 20522 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.