Bug 21339

Summary:	Possible test enhancements
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	low
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2009-04-22 06:27:42 UTC

match_jingle_action should be curried: almost every use is lambda e: jp.match_jingle_action(e.query, 'session-initiate') or similar.

Extract NewChannels-checking boilerplate.

Rename make_channel_proxy: wrap_channel should be used for channels, and the former only for SessionHandlers and StreamHandlers.

Comment 1 Will Thompson 2009-04-22 11:39:10 UTC

Done the second one in a branch; will rearrange patches and put it up for review at some point.

Comment 2 Will Thompson 2009-06-02 10:36:04 UTC

I never did finish extracting the NewChannels-checking boilerplate, but I did add a curried and flipped version of match_jingle_action, namely action_predicate.

Comment 3 GitLab Migration User 2019-12-03 19:19:04 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/29.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.