Bug 21795

Summary: [next] tp_proxy_add_interface_by_id should return void
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-glibAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: lowest CC: jonny.lamb
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
Whiteboard: ABI-break
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 31668    
Attachments: tp_proxy_add_interface_by_id: return void

Description Simon McVittie 2009-05-18 06:51:44 UTC 
From Will's recent patch correcting the documentation:

 494  * Returns: either %NULL or a borrowed #DBusGProxy corresponding to @interface,
 495  * depending on implementation details. To reliably borrow the #DBusGProxy, use
 496  * tp_proxy_borrow_interface_by_id(). (This method should probably have
 497  * returned void; sorry.)

(We don't want to make the DBusGProxy until it's strictly needed, so trying to return it here is undesirable.)
Comment 1 Simon McVittie 2012-03-02 08:53:54 UTC 
Created attachment 57931 [details] [review]
tp_proxy_add_interface_by_id: return void
Comment 2 Jonny Lamb 2012-03-02 14:31:50 UTC 
Comment on attachment 57931 [details] [review]
tp_proxy_add_interface_by_id: return void

Review of attachment 57931 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 3 Simon McVittie 2012-03-07 05:15:37 UTC 
Fixed in next

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.