Bug 21795 - [next] tp_proxy_add_interface_by_id should return void
Summary: [next] tp_proxy_add_interface_by_id should return void
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: lowest enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
Whiteboard: ABI-break
Keywords: patch
Depends on:
Blocks: tp-glib-1.0
  Show dependency treegraph
Reported: 2009-05-18 06:51 UTC by Simon McVittie
Modified: 2012-03-07 05:15 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

tp_proxy_add_interface_by_id: return void (2.36 KB, patch)
2012-03-02 08:53 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2009-05-18 06:51:44 UTC
From Will's recent patch correcting the documentation:

 494  * Returns: either %NULL or a borrowed #DBusGProxy corresponding to @interface,
 495  * depending on implementation details. To reliably borrow the #DBusGProxy, use
 496  * tp_proxy_borrow_interface_by_id(). (This method should probably have
 497  * returned void; sorry.)

(We don't want to make the DBusGProxy until it's strictly needed, so trying to return it here is undesirable.)
Comment 1 Simon McVittie 2012-03-02 08:53:54 UTC
Created attachment 57931 [details] [review]
tp_proxy_add_interface_by_id: return void
Comment 2 Jonny Lamb 2012-03-02 14:31:50 UTC
Comment on attachment 57931 [details] [review]
tp_proxy_add_interface_by_id: return void

Review of attachment 57931 [details] [review]:

Looks good.
Comment 3 Simon McVittie 2012-03-07 05:15:37 UTC
Fixed in next

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.