| Summary: | Calls g_critical if GetSessionHandlers fails | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | tp-farsight | Assignee: | Olivier Crête <olivier.crete> |
| Status: | RESOLVED WONTFIX | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
I agree.. How do I fail it ? Calling Close() sounds savage to me.. And I don't have a StreamHandler to call Error() on.. (In reply to comment #1) > I agree.. How do I fail it ? Calling Close() sounds savage to me.. I think Close() is the best you can do here. If GetSessionHandlers fails, then the channel's implementation of MediaSignalling is pretty incompetent, tbh :-) Group.RemoveMembersWithReason([self_handle], "", Group_Change_Reason_Error) ? (In reply to comment #3) > Group.RemoveMembersWithReason([self_handle], "", Group_Change_Reason_Error) ? Or that, yes. I'd be inclined to follow up with Close() if it fails (like MC does when ending channels in this way), since this code path is only entered if the CM is already broken... Tp-Farsight is obsolete, so is StreamHandler and the rest of StreamedMedia |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
In get_session_handlers_cb, tp-fs has: g_critical ("Error calling GetSessionHandlers: %s", error->message); I don't think criticaling is really appropriate here; the call should fail.