Bug 21876 - Calls g_critical if GetSessionHandlers fails
Summary: Calls g_critical if GetSessionHandlers fails
Status: RESOLVED WONTFIX
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-farsight (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Olivier Crête
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-22 07:29 UTC by Will Thompson
Modified: 2013-09-26 00:31 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-05-22 07:29:08 UTC 
In get_session_handlers_cb, tp-fs has:

  g_critical ("Error calling GetSessionHandlers: %s", error->message);

I don't think criticaling is really appropriate here; the call should fail.
Comment 1 Olivier Crête 2010-05-26 19:05:40 UTC 
I agree.. How do I fail it ? Calling Close() sounds savage to me.. And I don't have a StreamHandler to call Error() on..
Comment 2 Simon McVittie 2010-05-27 03:36:48 UTC 
(In reply to comment #1)
> I agree.. How do I fail it ? Calling Close() sounds savage to me..

I think Close() is the best you can do here. If GetSessionHandlers fails, then the channel's implementation of MediaSignalling is pretty incompetent, tbh :-)
Comment 3 Will Thompson 2010-05-27 03:49:01 UTC 
Group.RemoveMembersWithReason([self_handle], "", Group_Change_Reason_Error) ?
Comment 4 Simon McVittie 2010-05-27 03:57:49 UTC 
(In reply to comment #3)
> Group.RemoveMembersWithReason([self_handle], "", Group_Change_Reason_Error) ?

Or that, yes. I'd be inclined to follow up with Close() if it fails (like MC does when ending channels in this way), since this code path is only entered if the CM is already broken...
Comment 5 Olivier Crête 2013-09-26 00:31:04 UTC 
Tp-Farsight is obsolete, so is StreamHandler and the rest of StreamedMedia

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.