Bug 2194

Summary: XScreenSaverSetAttributes broken on 64 bit architectures
Product: xorg Reporter: Matthieu Herrb <matthieu.herrb>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: ajax, alan.coopersmith, roland.mainz
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
proposed patch matthieu.herrb: 6.8-branch?

Description Matthieu Herrb 2005-01-02 13:58:03 UTC 
Lauching beforelight on OpenBSD/amd64 or OpenBSD/amd64 lead to a BadColor error:
X Error of failed request:  BadColor (invalid Colormap parameter)
  Major opcode of failed request:  136 (MIT-SCREEN-SAVER)
  Minor opcode of failed request:  3 ()
  Resource id in failed request:  0x2b000001
  Serial number of failed request:  94
  Current serial number in output stream:  95

Afaict, this is caused by a mismatch in the length of the fields used to decode
the request in Xext/saver.c. The attached patch is a proposed fix, but I'm not 
sure if it's correct. It would be great if someone more familiar then me with
the request decoding code checked that before I commit it.
Comment 1 Matthieu Herrb 2005-01-02 13:58:42 UTC 
Created attachment 1613 [details] [review]
proposed patch
Comment 2 Roland Mainz 2005-01-02 14:58:52 UTC 
Maybe Alan can help... CC:'ing him to take a look at the patch...
Comment 3 Adam Jackson 2005-03-22 13:44:13 UTC 
looks good to me, matthieu.
Comment 4 Alan Coopersmith 2005-03-22 13:48:38 UTC 
(In reply to comment #2)
> Maybe Alan can help... CC:'ing him to take a look at the patch...

Sorry, I've never looked at this code before and don't know anything about it,
so I don't qualify as "someone more familiar than" Mattheiu.

I don't see anything wrong with it, per se, but I can't claim I'm sure it's
correct either.
Comment 5 Matthieu Herrb 2005-03-23 13:11:09 UTC 
Patch commited to HEAD

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.