Lauching beforelight on OpenBSD/amd64 or OpenBSD/amd64 lead to a BadColor error: X Error of failed request: BadColor (invalid Colormap parameter) Major opcode of failed request: 136 (MIT-SCREEN-SAVER) Minor opcode of failed request: 3 () Resource id in failed request: 0x2b000001 Serial number of failed request: 94 Current serial number in output stream: 95 Afaict, this is caused by a mismatch in the length of the fields used to decode the request in Xext/saver.c. The attached patch is a proposed fix, but I'm not sure if it's correct. It would be great if someone more familiar then me with the request decoding code checked that before I commit it.
Created attachment 1613 [details] [review] proposed patch
Maybe Alan can help... CC:'ing him to take a look at the patch...
looks good to me, matthieu.
(In reply to comment #2) > Maybe Alan can help... CC:'ing him to take a look at the patch... Sorry, I've never looked at this code before and don't know anything about it, so I don't qualify as "someone more familiar than" Mattheiu. I don't see anything wrong with it, per se, but I can't claim I'm sure it's correct either.
Patch commited to HEAD
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.