| Summary: | [regression] Re-implement keep-alive support | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | gabble | Assignee: | Senko Rasic <senko.rasic> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | compnerd |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/ptlo/telepathy-gabble/.git;a=shortlog;h=refs/heads/ping | ||
| Whiteboard: | review-, style tweaks | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 23644 | ||
| Bug Blocks: | |||
|
Description
Guillaume Desmottes
2009-09-02 02:22:28 UTC
Here's a branch by Senko! Much as I hate to nit-pick such a tiny branch... + if (priv->pinger != NULL) + g_object_set (priv->pinger, "ping-interval", + priv->keepalive_interval, NULL); ...the g_object_set is indented too far, and... + priv->pinger = wocky_ping_new (priv->porter, + priv->keepalive_interval); ...this doesn't really need to be wrapped! I am happy that the branch can be this small :) (In reply to comment #2) > ...the g_object_set is indented too far, and... > ...this doesn't really need to be wrapped! Both fixed. Branch merged to master, thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.