Bug 23641 - [regression] Re-implement keep-alive support
Summary: [regression] Re-implement keep-alive support
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Senko Rasic
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/pt...
Whiteboard: review-, style tweaks
Keywords: patch
Depends on: 23644
Blocks:
  Show dependency tree / graph
 
Reported: 2009-09-02 02:22 UTC by Guillaume Desmottes
Modified: 2010-05-24 06:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Guillaume Desmottes 2009-09-02 02:22:28 UTC 
The Wocky port removed keep-alive support. We should re-implement it.
Comment 1 Will Thompson 2010-05-21 04:54:29 UTC 
Here's a branch by Senko!
Comment 2 Will Thompson 2010-05-21 04:58:49 UTC 
Much as I hate to nit-pick such a tiny branch...


+      if (priv->pinger != NULL)
+          g_object_set (priv->pinger, "ping-interval",
+              priv->keepalive_interval, NULL);

...the g_object_set is indented too far, and...

+  priv->pinger = wocky_ping_new (priv->porter,
+      priv->keepalive_interval);

...this doesn't really need to be wrapped!

I am happy that the branch can be this small :)
Comment 3 Senko Rasic 2010-05-24 06:26:56 UTC 
(In reply to comment #2)
> ...the g_object_set is indented too far, and...
> ...this doesn't really need to be wrapped!

Both fixed.

Branch merged to master, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.