| Summary: | [connector] Connection operations should support cancel | ||
|---|---|---|---|
| Product: | Wocky | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | General | Assignee: | Cosimo Cecchi <cosimoc> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | will |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 23642 | ||
|
Description
Guillaume Desmottes
2009-09-02 02:37:05 UTC
This is done in these branches Wocky: http://git.collabora.co.uk/?p=user/cosimoc/wocky.git;a=shortlog;h=refs/heads/cancel_connector Gabble: http://git.collabora.co.uk/?p=user/cosimoc/telepathy-gabble.git;a=shortlog;h=refs/heads/cancel-connector These branches are shockingly simple.
I think there should really be a test for this functionality in Wocky as well as in Gabble, but I appreciate why you might not want to bother. :)
/* FIXME: support keep alive */
Could you bin this while you're here? It's no longer true: we do support keep alives.
I think you forgot to commit an update to lib/ext/wocky?
+ DEBUG ("Cancelling the porter connection");
+
+ if (priv->cancellable != NULL)
Why would priv->cancellable be NULL? Surely if the connector isn't NULL, the cancellable shouldn't be either?
(In reply to comment #2) Thanks, I updated my branch according to your comments. awesomesauce. Merged both branches to master. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.