Bug 23643 - [connector] Connection operations should support cancel
Summary: [connector] Connection operations should support cancel
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Cosimo Cecchi
QA Contact:
URL:
Whiteboard: review+
Keywords:
Depends on:
Blocks: 23642
  Show dependency treegraph
 
Reported: 2009-09-02 02:37 UTC by Guillaume Desmottes
Modified: 2010-09-15 04:02 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2009-09-02 02:37:05 UTC
In order to fix #23642, the connecting process should be cancelable.
Comment 2 Will Thompson 2010-09-14 11:04:14 UTC
These branches are shockingly simple.

I think there should really be a test for this functionality in Wocky as well as in Gabble, but I appreciate why you might not want to bother. :)

   /* FIXME: support keep alive */

Could you bin this while you're here? It's no longer true: we do support keep alives.

I think you forgot to commit an update to lib/ext/wocky?

+      DEBUG ("Cancelling the porter connection");
+
+      if (priv->cancellable != NULL)

Why would priv->cancellable be NULL? Surely if the connector isn't NULL, the cancellable shouldn't be either?
Comment 3 Cosimo Cecchi 2010-09-15 02:44:49 UTC
(In reply to comment #2)

Thanks, I updated my branch according to your comments.
Comment 4 Will Thompson 2010-09-15 03:42:00 UTC
awesomesauce.
Comment 5 Cosimo Cecchi 2010-09-15 04:02:24 UTC
Merged both branches to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.