| Summary: | Some parameters should be uint rather than int | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Cosimo Cecchi <cosimoc> |
| Component: | haze | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-haze;a=shortlog;h=refs/heads/port-type | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Cosimo Cecchi
2009-09-04 04:21:03 UTC
Oh, I thought that Mission Control stored the types of parameters, which would make this hard to fix. But actually the type of the parameter isn't stored in the keyfile, so changing this parameter from int to uint wouldn't break accounts. Here's a branch fixing this. Whoops, my branch breaks the tests... Any chance of a re-review? I fixed the tests. (In reply to comment #4) > Any chance of a re-review? I fixed the tests. I'm disappointed with you, but your extra commits look fine. I am sorry. I shall walk on a bed of nails and think about what I have done. commit 57f31dac78ea87b5464133e88a4185cc3c2db44a Merge: bdfeaa9 780b919 Author: Will Thompson <will.thompson@collabora.co.uk> Date: Sun Jul 11 12:49:10 2010 +0100 Merge branch 'port-type' Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.