Bug 23702 - Some parameters should be uint rather than int
Summary: Some parameters should be uint rather than int
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-09-04 04:21 UTC by Cosimo Cecchi
Modified: 2010-07-11 04:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Cosimo Cecchi 2009-09-04 04:21:03 UTC 
param-port should always be uint
Probably also param-xfer-port for yahoo.
Comment 1 Will Thompson 2010-07-09 17:09:36 UTC 
Oh, I thought that Mission Control stored the types of parameters, which would make this hard to fix.

But actually the type of the parameter isn't stored in the keyfile, so changing this parameter from int to uint wouldn't break accounts.
Comment 2 Will Thompson 2010-07-09 17:59:58 UTC 
Here's a branch fixing this.
Comment 3 Will Thompson 2010-07-11 02:52:58 UTC 
Whoops, my branch breaks the tests...
Comment 4 Will Thompson 2010-07-11 02:59:44 UTC 
Any chance of a re-review? I fixed the tests.
Comment 5 Jonny Lamb 2010-07-11 04:33:49 UTC 
(In reply to comment #4)
> Any chance of a re-review? I fixed the tests.

I'm disappointed with you, but your extra commits look fine.
Comment 6 Will Thompson 2010-07-11 04:55:29 UTC 
I am sorry. I shall walk on a bed of nails and think about what I have done.

commit 57f31dac78ea87b5464133e88a4185cc3c2db44a
Merge: bdfeaa9 780b919
Author: Will Thompson <will.thompson@collabora.co.uk>
Date:   Sun Jul 11 12:49:10 2010 +0100

    Merge branch 'port-type'
    
    Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.