Bug 25278

Summary:	BytestreamMultiple may never signal failure
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2009-11-25 05:41:44 UTC

I was looking at bytestream-multiple.c from the point of view of trying to make bytestream_connection_error_cb a bit easier to follow. (Currently it sets priv->active_bytestream to NULL, calls some method, and then uses priv->active_bytestream, which is surprising. Also, bytestream_activate_next() asserts that there are some fallback methods available, rather than failing gracefully if there are not.)

Looking over it has made me suspicious that BytestreamMultiple's state never changes to Closed. As far as I can tell, it's only updated in bytestream_state_changed_cb(), which has a comment explaining (apparently) why it will never be called for Closed.

Comment 1 GitLab Migration User 2019-12-03 19:21:17 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/64.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.