Bug 25278 - BytestreamMultiple may never signal failure
Summary: BytestreamMultiple may never signal failure
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 05:41 UTC by Will Thompson
Modified: 2009-11-25 05:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Thompson 2009-11-25 05:41:44 UTC
I was looking at bytestream-multiple.c from the point of view of trying to make bytestream_connection_error_cb a bit easier to follow. (Currently it sets priv->active_bytestream to NULL, calls some method, and then uses priv->active_bytestream, which is surprising. Also, bytestream_activate_next() asserts that there are some fallback methods available, rather than failing gracefully if there are not.)

Looking over it has made me suspicious that BytestreamMultiple's state never changes to Closed. As far as I can tell, it's only updated in bytestream_state_changed_cb(), which has a comment explaining (apparently) why it will never be called for Closed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.