Bug 25384

Summary:	Failing accounts should not stop AM from becoming prepared.
Product:	Telepathy	Reporter:	David Laban <david.laban>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	24209

Description David Laban 2009-12-01 16:02:19 UTC

Found while trying to improve test coverage in AccountManager.

Tests and fix can be found at http://git.collabora.co.uk/?p=user/alsuren/telepathy-glib.git;a=shortlog;h=refs/heads/tests

Comment 1 Simon McVittie 2009-12-02 07:41:35 UTC

The code changes seem fine but the branch could do with some rebase --interactive action:

* "oops: ignore generated session.conf" would have been better squashed into "Don't let MC5..."

* the commit message for "TESTS FAIL: ..." doesn't describe what you changed or why, please do that

* "Remove any account which ..." should be "fd.o #25384: remove ..."

* The fix for this bug should come before the regression-test changes that exercise it, so that tests pass at every step

* while you're rebasing anyway, it would be nice if the branch was based on current master

Comment 2 David Laban 2009-12-02 10:47:33 UTC

Merged in master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.