| Summary: | requesting a DBusTube returns a Tubes channel | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Youness Alaoui <youness.alaoui> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/jonny/telepathy-gabble.git;a=shortlog;h=refs/heads/25533 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | dbus monitor log | ||
So the reason you only sometimes saw it was because the bug wouldn't be seen if the MUC channel is already ready (you've already opened a text chat with the TargetID). However, when it is *not* ready, the request token is associated with the tubes channel, even if that wasn't what was requested. See my branch to fix this. the branch in the first hunk of dc07f869bb2b08234b08ace9ff35015b1060a395 is never taken, you can just remove that code otherwise it looks good Thanks for the review. Merged to master. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 31867 [details] dbus monitor log doing a CreateChannel (or RequestChannel) on gabble for a type DBusTube leads sometimes to a Tubes channel and no DBusTube channel is created... attached log shows the same request sent on two different accounts, one works, the other one doesn't... (search for serial 3859) gabble log will be provided tomorrow