Bug 25533 - requesting a DBusTube returns a Tubes channel
Summary: requesting a DBusTube returns a Tubes channel
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-12-08 21:27 UTC by Youness Alaoui
Modified: 2010-07-14 06:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
dbus monitor log (168.89 KB, text/plain)
2009-12-08 21:27 UTC, Youness Alaoui
Details

Description Youness Alaoui 2009-12-08 21:27:41 UTC
Created attachment 31867 [details]
dbus monitor log

doing a CreateChannel (or RequestChannel) on gabble for a type DBusTube leads sometimes to a Tubes channel and no DBusTube channel is created... attached log shows the same request sent on two different accounts, one works, the other one doesn't... (search for serial 3859)
gabble log will be provided tomorrow
Comment 1 Jonny Lamb 2010-07-08 09:26:25 UTC
So the reason you only sometimes saw it was because the bug wouldn't be seen if the MUC channel is already ready (you've already opened a text chat with the TargetID). However, when it is *not* ready, the request token is associated with the tubes channel, even if that wasn't what was requested.

See my branch to fix this.
Comment 2 Sjoerd Simons 2010-07-14 04:49:49 UTC
the branch in the first hunk of dc07f869bb2b08234b08ace9ff35015b1060a395 is never taken, you can just remove that code otherwise it looks good
Comment 3 Jonny Lamb 2010-07-14 06:37:20 UTC
Thanks for the review. Merged to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.