| Summary: | [QUIRKS] Invalid syntax of OR in regex | ||
|---|---|---|---|
| Product: | pm-utils | Reporter: | Rafał Miłecki <zajec5> |
| Component: | General | Assignee: | Richard Hughes <richard> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
regex.sh to show problem with current OR syntax
Patch that made pm-utils pick quirks for my VGN-FW11S Fix typo in regexp, replacing ; char |
||
|
Description
Rafał Miłecki
2010-01-28 06:36:02 UTC
Created attachment 32868 [details]
regex.sh to show problem with current OR syntax
Created attachment 32869 [details] [review] Patch that made pm-utils pick quirks for my VGN-FW11S This report is against pm-quirks-20091205.tar.gz Martin Pitt tried to fix this other way, by replacing ";" with "|" when parsing regexp. Unfortunately it doesn't work because of typo in Martin's modification. Created attachment 33042 [details] [review] Fix typo in regexp, replacing ; char Oh, to replace all instances, indeed. Thanks for catching! Completely fixed in commit 8fb0119543fc186786ff5dd10cccab066ede1860 "Fix typo in regexp, replacing ; char" Thanks Rafał, I pushed your fix. Ultimately, I think we should directly use "|" in the database to avoid this unnecessary conversion in 98-video-quirk-db-handler. Theoretically, import-fdi-quirkdb should already do that but apparently it doesn't. We should also update pm-quirks-20091205.tar.gz based on the latest hal-info release 20091130. I'll reopen until we got some input from Victor on this matter This was fixed in February's release of pm-quirks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.