Bug 26296 - [QUIRKS] Invalid syntax of OR in regex
Summary: [QUIRKS] Invalid syntax of OR in regex
Status: RESOLVED FIXED
Alias: None
Product: pm-utils
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 06:36 UTC by Rafał Miłecki
Modified: 2010-07-04 07:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
regex.sh to show problem with current OR syntax (140 bytes, text/plain)
2010-01-28 06:36 UTC, Rafał Miłecki 		Details
Patch that made pm-utils pick quirks for my VGN-FW11S (514 bytes, patch)
2010-01-28 06:38 UTC, Rafał Miłecki 		Details | Splinter Review
Fix typo in regexp, replacing ; char (937 bytes, patch)
2010-02-03 12:29 UTC, Rafał Miłecki 		Details | Splinter Review
View All

Description Rafał Miłecki 2010-01-28 06:36:02 UTC 
video-quirks use invalid syntax for OR.
Comment 1 Rafał Miłecki 2010-01-28 06:36:36 UTC 
Created attachment 32868 [details]
regex.sh to show problem with current OR syntax
Comment 2 Rafał Miłecki 2010-01-28 06:38:50 UTC 
Created attachment 32869 [details] [review]
Patch that made pm-utils pick quirks for my VGN-FW11S
Comment 3 Rafał Miłecki 2010-01-28 06:40:04 UTC 
This report is against pm-quirks-20091205.tar.gz
Comment 4 Rafał Miłecki 2010-02-03 12:29:14 UTC 
Martin Pitt tried to fix this other way, by replacing ";" with "|" when parsing regexp. Unfortunately it doesn't work because of typo in Martin's modification.
Comment 5 Rafał Miłecki 2010-02-03 12:29:44 UTC 
Created attachment 33042 [details] [review]
Fix typo in regexp, replacing ; char
Comment 6 Martin Pitt 2010-02-03 12:48:50 UTC 
Oh, to replace all instances, indeed. Thanks for catching!
Comment 7 Rafał Miłecki 2010-02-03 13:14:19 UTC 
Completely fixed in commit 8fb0119543fc186786ff5dd10cccab066ede1860
"Fix typo in regexp, replacing ; char"
Comment 8 Michael Biebl 2010-02-03 13:17:03 UTC 
Thanks Rafał, I pushed your fix.

Ultimately, I think we should directly use "|" in the database to avoid this unnecessary conversion in 98-video-quirk-db-handler.

Theoretically, import-fdi-quirkdb should already do that but apparently it doesn't. We should also update 	pm-quirks-20091205.tar.gz based on the latest hal-info release 20091130.

I'll reopen until we got some input from Victor on this matter
Comment 9 Victor Lowther 2010-07-04 07:33:10 UTC 
This was fixed in February's release of pm-quirks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.