| Summary: | support yuv offscreen image without overlay in v4l.c | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Yannick Henault <yheneaul> |
| Component: | Driver/other | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | high | CC: | alexdeucher, eich, roland.mainz |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Egbert: Any idea who can review the patch ? Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. That patch doesn't seem to be related to current code, so I'm going to assume this was fixed at some point in the past 5 years. If not, you should email Mauro Carvalho Chehab <mchehab@redhat.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Is it possible the following patch in driver/v4l.c file? It handles the case were yuv is supported by a driver implementing offscreen image but doing it without overlay (the overlay flag is not set). In that case, the stop method of the offscreen image must be called because some device on the video card is converting and scaling yuv to rgb and blitting directly to the frame buffer continuously. *************** *** 495,501 **** if (-1 == ioctl(V4L_FD, VIDIOCCAPTURE, &zero)) perror("ioctl VIDIOCCAPTURE(0)"); pPPriv->VideoOn = VIDEO_RECLIP; ! } } else { /* video stop - turn off and free everything */ if (VIDEO_YUV == pPPriv->VideoOn) { --- 495,504 ---- if (-1 == ioctl(V4L_FD, VIDIOCCAPTURE, &zero)) perror("ioctl VIDIOCCAPTURE(0)"); pPPriv->VideoOn = VIDEO_RECLIP; ! } else if (VIDEO_YUV == pPPriv->VideoOn && ! (pPPriv->myfmt->flags & VIDEO_OVERLAID_IMAGES) == 0) { ! pPPriv->myfmt->stop(pPPriv->surface); ! } } else { /* video stop - turn off and free everything */ if (VIDEO_YUV == pPPriv->VideoOn) {