Bug 2634 - support yuv offscreen image without overlay in v4l.c
Summary: support yuv offscreen image without overlay in v4l.c
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/other (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-01 12:23 UTC by Yannick Henault
Modified: 2011-10-17 02:31 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Yannick Henault 2005-03-01 12:23:40 UTC
Is it possible the following patch in driver/v4l.c file? It handles the case 
were yuv is supported by a driver implementing offscreen image but doing it 
without overlay (the overlay flag is not set). In that case, the stop method of 
the offscreen image must be called because some device on the video card is 
converting and scaling yuv to rgb and blitting directly to the frame buffer 
continuously. 
 
*************** 
*** 495,501 **** 
            if (-1 == ioctl(V4L_FD, VIDIOCCAPTURE, &zero)) 
                perror("ioctl VIDIOCCAPTURE(0)"); 
            pPPriv->VideoOn = VIDEO_RECLIP; 
!       } 
      } else { 
        /* video stop - turn off and free everything */ 
        if (VIDEO_YUV == pPPriv->VideoOn) { 
--- 495,504 ---- 
            if (-1 == ioctl(V4L_FD, VIDIOCCAPTURE, &zero)) 
                perror("ioctl VIDIOCCAPTURE(0)"); 
            pPPriv->VideoOn = VIDEO_RECLIP; 
!       } else if (VIDEO_YUV == pPPriv->VideoOn && 
!                    (pPPriv->myfmt->flags & VIDEO_OVERLAID_IMAGES) == 0) { 
!             pPPriv->myfmt->stop(pPPriv->surface); 
!         } 
      } else { 
        /* video stop - turn off and free everything */ 
        if (VIDEO_YUV == pPPriv->VideoOn) {
Comment 1 Roland Mainz 2005-03-01 23:06:34 UTC
Egbert:
Any idea who can review the patch ?
Comment 2 Daniel Stone 2007-02-27 01:25:37 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Jeremy Huddleston Sequoia 2011-10-17 02:27:58 UTC
That patch doesn't seem to be related to current code, so I'm going to assume 
this was fixed at some point in the past 5 years.  If not, you should email 
Mauro Carvalho Chehab <mchehab@redhat.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.