| Summary: | review needed for log-entry-refactoring | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Cosimo Alfarano <cosimo.alfarano> |
| Component: | logger | Assignee: | Danielle Madeley <danielle> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/kalfa/telepathy-logger.git;a=shortlog;h=refs/heads/log-entry-refactoring | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Cosimo Alfarano
2010-02-18 12:12:57 UTC
@@ -459,9 +461,22 @@ add_message_text_chat (TplLogStore *self,
chatroom = tpl_log_entry_text_is_chatroom (message);
sender = tpl_log_entry_get_sender (TPL_LOG_ENTRY (message));
- account =
- tpl_channel_get_account (TPL_CHANNEL (
- tpl_log_entry_text_get_tpl_channel_text (message)));
+
+ bus_daemon = tp_dbus_daemon_dup (error);
+ if (bus_daemon == NULL)
+ {
+ DEBUG ("Error acquiring bus daemon: %s", (*error)->message);
+ return FALSE;
+ }
Doesn't unref bus_daemon ?
+ account = tp_account_new (bus_daemon,
+ tpl_log_entry_get_account_path (TPL_LOG_ENTRY (message)), error);
+ if (account == NULL)
+ {
+ DEBUG ("Error acquiring TpAccount proxy: %s", (*error)->message);
+ return FALSE;
+ }
Doesn't unref account?
+ priv->account_path = g_strdup (data);
Not free'd on dispose/finalize ?
changed commited to the same branch (In reply to comment #2) > changed commited to the same branch > Ok. Looks good. Squash this patch into the previous one and merge to master. squashed and merged to master. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.