Bug 26636 - review needed for log-entry-refactoring
Summary: review needed for log-entry-refactoring
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Danielle Madeley
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ka...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-18 12:12 UTC by Cosimo Alfarano
Modified: 2010-02-22 06:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Comment 1 Danielle Madeley 2010-02-18 18:58:42 UTC
@@ -459,9 +461,22 @@ add_message_text_chat (TplLogStore *self,
   chatroom = tpl_log_entry_text_is_chatroom (message);
 
   sender = tpl_log_entry_get_sender (TPL_LOG_ENTRY (message));
-  account =
-    tpl_channel_get_account (TPL_CHANNEL (
-          tpl_log_entry_text_get_tpl_channel_text (message)));
+
+  bus_daemon = tp_dbus_daemon_dup (error);
+  if (bus_daemon == NULL)
+    {
+      DEBUG ("Error acquiring bus daemon: %s", (*error)->message);
+      return FALSE;
+    }

Doesn't unref bus_daemon ?

+  account = tp_account_new (bus_daemon,
+      tpl_log_entry_get_account_path (TPL_LOG_ENTRY (message)), error);
+  if (account == NULL)
+    {
+      DEBUG ("Error acquiring TpAccount proxy: %s", (*error)->message);
+      return FALSE;
+    }

Doesn't unref account?

+  priv->account_path = g_strdup (data);

Not free'd on dispose/finalize ?
Comment 2 Cosimo Alfarano 2010-02-19 06:54:52 UTC
changed commited to the same branch
Comment 3 Danielle Madeley 2010-02-21 16:35:52 UTC
(In reply to comment #2)
> changed commited to the same branch
> 

Ok. Looks good. Squash this patch into the previous one and merge to master.
Comment 4 Cosimo Alfarano 2010-02-22 06:24:07 UTC
squashed and merged to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.