Bug 27352

Summary:

RPMLINT error causes build breakage [xf86-video-intel]

Product:

xorg

Reporter:

Johannes Obermayr <johannesobermayr>

Component:

Driver/intel

Assignee:

Carl Worth <cworth>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Version:

git

Hardware:

Other

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Patch	none

Description Johannes Obermayr 2010-03-28 08:44:29 UTC

RPMLINT error:

I: Program returns random data in a function
E: xorg-x11-driver-video no-return-in-nonvoid-function i965_xvmc.c:222
E: xorg-x11-driver-video no-return-in-nonvoid-function xvmc_vld.c:373

Comment 1 Johannes Obermayr 2010-05-04 00:30:50 UTC

Created attachment 35405 [details] [review]
Patch

Patch by Stefan Dirsch (openSUSE).

Comment 2 Chris Wilson 2010-05-11 11:40:17 UTC

Slightly different approach as the return values where not used, we could simply change the prototypes. Thank you for the bug report.

commit 6ea8ce640fbc7e5054b521a6f70b303945d0e849
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue May 11 19:35:59 2010 +0100

    xvmc: Build fix with -pedantic
    
    Fixes:
    
      Bug 27352 - RPMLINT error causes build breakage
      https://bugs.freedesktop.org/show_bug.cgi?id=27352
    
    Reported-by: Johannes Obermayr <johannesobermayr@gmx.de>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.