Bug 27352 - RPMLINT error causes build breakage [xf86-video-intel]
Summary: RPMLINT error causes build breakage [xf86-video-intel]
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: Carl Worth
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-28 08:44 UTC by Johannes Obermayr
Modified: 2010-05-11 11:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch (776 bytes, patch)
2010-05-04 00:30 UTC, Johannes Obermayr 		no flags Details | Splinter Review
View All

Description Johannes Obermayr 2010-03-28 08:44:29 UTC 
RPMLINT error:

I: Program returns random data in a function
E: xorg-x11-driver-video no-return-in-nonvoid-function i965_xvmc.c:222
E: xorg-x11-driver-video no-return-in-nonvoid-function xvmc_vld.c:373
Comment 1 Johannes Obermayr 2010-05-04 00:30:50 UTC 
Created attachment 35405 [details] [review]
Patch

Patch by Stefan Dirsch (openSUSE).
Comment 2 Chris Wilson 2010-05-11 11:40:17 UTC 
Slightly different approach as the return values where not used, we could simply change the prototypes. Thank you for the bug report.

commit 6ea8ce640fbc7e5054b521a6f70b303945d0e849
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue May 11 19:35:59 2010 +0100

    xvmc: Build fix with -pedantic
    
    Fixes:
    
      Bug 27352 - RPMLINT error causes build breakage
      https://bugs.freedesktop.org/show_bug.cgi?id=27352
    
    Reported-by: Johannes Obermayr <johannesobermayr@gmx.de>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.