Bug 27488

Summary:	re-order some arguments to put the GError ** at the end, to be nice to Vala
Product:	Wocky	Reporter:	Simon McVittie <smcv>
Component:	General	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	ole.andre.ravnas
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/wocky.git;a=shortlog;h=refs/heads/be-nice-to-vala
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	27244
Bug Blocks:

Description Simon McVittie 2010-04-06 07:13:46 UTC

Cloned from Bug #27244:

> One more thing, slightly off-topic, would you be okay with changing
> wocky_connector_{connect,register}_finish so the GError is put as the last
> argument instead of middle? That would make Vala async binding "just work". :-)

Comment 1 Simon McVittie 2010-04-20 08:04:32 UTC

Sorry, the branch URL here was an artefact of the bug having been cloned.

Comment 2 Simon McVittie 2010-06-15 06:57:58 UTC

See URL for a patch to do this in the simple cases. I didn't alter wocky_stanza_extract_errors or wocky_xmpp_error_extract, because they don't fit the usual pattern anyway.

Comment 3 Simon McVittie 2010-06-15 07:45:52 UTC

Fixed in git, will be in the Gabble 0.9.14 snapshot.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.